linux-kernel - Re: [PATCH v3] mwifiex: fix sleep in atomic context bugs caused by dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 May 2022 09:54:29 +0800 (GMT+08:00)
From:   duoming@....edu.cn
To:     "Brian Norris" <briannorris@...omium.org>
Cc:     "Eric W. Biederman" <ebiederm@...ssion.com>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        "amit karwar" <amitkarwar@...il.com>,
        "Ganapathi Bhat" <ganapathi017@...il.com>,
        "Sharvari Harisangam" <sharvari.harisangam@....com>,
        "Xinming Hu" <huxinming820@...il.com>, kvalo@...nel.org,
        "David S. Miller" <davem@...emloft.net>, edumazet@...gle.com,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>,
        "Linux Kernel" <linux-kernel@...r.kernel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "Johannes Berg" <johannes@...solutions.net>
Subject: Re: [PATCH v3] mwifiex: fix sleep in atomic context bugs caused by
 dev_coredumpv

Hello,

On Mon, 23 May 2022 12:42:44 -0700 Brian wrote:

> (I think people generally agreed on this approach, but please submit a
> new series, with separate patches)
> 
> On Mon, May 23, 2022 at 12:27 PM <duoming@....edu.cn> wrote:
> > What's more, I move the operations that may sleep into a work item and use
> > schedule_work() to call a kernel thread to do the operations that may sleep.
> 
> You end up with a timer that just exists to kick a work item. Eric
> suggested you just use a delayed_work, and then you don't need both a
> timer and a work struct.

I will submit a new series, one is removing the gfp_t parameter of dev_coredumpv,
another is using it properly in mwifiex(put the dev_coredumpv in the delayed_work).
Thank you for your suggestions!

Best regards,
Duoming Zhou