linux-kernel - Re: [PATCH v2 3/3] selftests/filesystems: add a vfat RENAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <170151f7-9d46-6b01-e281-0f675a3b523f@collabora.com>
Date:   Tue, 24 May 2022 19:54:07 +0500
From:   Muhammad Usama Anjum <usama.anjum@...labora.com>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     usama.anjum@...labora.com,
        Chung-Chiang Cheng <cccheng@...ology.com>,
        Lennart Poettering <lennart@...ttering.net>,
        Colin Walters <walters@...bum.org>,
        Peter Jones <pjones@...hat.com>,
        Alexander Larsson <alexl@...hat.com>,
        Alberto Ruiz <aruiz@...hat.com>,
        Christian Kellner <ckellner@...hat.com>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 3/3] selftests/filesystems: add a vfat RENAME_EXCHANGE
 test

On 5/24/22 12:36 PM, Javier Martinez Canillas wrote:
> diff --git a/tools/testing/selftests/filesystems/fat/Makefile b/tools/testing/selftests/filesystems/fat/Makefile
> new file mode 100644
> index 000000000000..93ee73c16828
> --- /dev/null
> +++ b/tools/testing/selftests/filesystems/fat/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +TEST_PROGS := run_fat_tests.sh
> +TEST_GEN_PROGS_EXTENDED := rename_exchange
Please create a .gitignore file and add rename_exchange to it.

> +CFLAGS += -O2 -g -Wall -I../../../../usr/include/
Build may fail if kernel on which this test is being build has old
headers. Always use $(KHDR_INCLUDES) instead of
"-I../../../../usr/include/" to use the kernel headers from the kernel
source instead of the natively installed headers.

-- 
Muhammad Usama Anjum