linux-kernel - Re: [PATCH] ath6kl: Use cc-disable-warning to disable -Wdangling-pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 May 2022 17:38:14 +0200
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Kalle Valo <kvalo@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, "kernelci.org bot" <bot@...nelci.org>
Subject: Re: [PATCH] ath6kl: Use cc-disable-warning to disable -Wdangling-pointer

From: Nathan Chancellor <nathan@...nel.org>
Date: Tue, 24 May 2022 07:56:55 -0700

> Clang does not support this option so the build fails:
> 
>   error: unknown warning option '-Wno-dangling-pointer' [-Werror,-Wunknown-warning-option]
> 
> Use cc-disable-warning so that the option is only added when it is
> supported.
> 
> Fixes: bd1d129daa3e ("wifi: ath6k: silence false positive -Wno-dangling-pointer warning on GCC 12")
> Reported-by: "kernelci.org bot" <bot@...nelci.org>
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

I was just about to send it :D

Reviewed-and-tested-by: Alexander Lobakin <alexandr.lobakin@...el.com>

> ---
>  drivers/net/wireless/ath/ath6kl/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath6kl/Makefile b/drivers/net/wireless/ath/ath6kl/Makefile
> index 01cc0d50fee6..a75bfa9fd1cf 100644
> --- a/drivers/net/wireless/ath/ath6kl/Makefile
> +++ b/drivers/net/wireless/ath/ath6kl/Makefile
> @@ -38,7 +38,7 @@ ath6kl_core-y += recovery.o
>  
>  # FIXME: temporarily silence -Wdangling-pointer on non W=1+ builds
>  ifndef KBUILD_EXTRA_WARN
> -CFLAGS_htc_mbox.o += -Wno-dangling-pointer
> +CFLAGS_htc_mbox.o += $(call cc-disable-warning, dangling-pointer)
>  endif
>  
>  ath6kl_core-$(CONFIG_NL80211_TESTMODE) += testmode.o
> 
> base-commit: 677fb7525331375ba2f90f4bc94a80b9b6e697a3
> -- 
> 2.36.1

Thanks,
Al