linux-kernel - Re: [PATCH] RDMA/rxe: Fix an error handling path in rxe_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 May 2022 12:56:42 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     dan.carpenter@...cle.com, Zhu Yanjun <zyjzyj2000@...il.com>,
        Leon Romanovsky <leon@...nel.org>,
        Bob Pearson <rpearsonhpe@...il.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH] RDMA/rxe: Fix an error handling path in rxe_get_mcg()

On Sun, May 22, 2022 at 03:25:08PM +0200, Christophe JAILLET wrote:
> The commit in the Fixes tag has shuffled some code.
> Now 'mcg_num' is incremented before the kzalloc(). So if the memory
> allocation fails, this increment must be undone.
> 
> Fixes: a926a903b7dc ("RDMA/rxe: Do not call dev_mc_add/del() under a spinlock")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/infiniband/sw/rxe/rxe_mcast.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied to for-next, thanks

Jason