linux-kernel - Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c22de8df-0599-0a86-146a-267f576f5500@deltatee.com>
Date:   Tue, 24 May 2022 09:55:51 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Donald Buczek <buczek@...gen.mpg.de>, linux-kernel@...r.kernel.org,
        linux-raid@...r.kernel.org, Song Liu <song@...nel.org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Guoqing Jiang <guoqing.jiang@...ux.dev>,
        Xiao Ni <xni@...hat.com>, Stephen Bates <sbates@...thlin.com>,
        Martin Oliveira <Martin.Oliveira@...eticom.com>,
        David Sloan <David.Sloan@...eticom.com>
Subject: Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log
 accesses



On 2022-05-22 01:32, Donald Buczek wrote:
>>   /*
>> @@ -703,7 +720,7 @@ static void r5c_disable_writeback_async(struct work_struct *work)
>>   
>>   	/* wait superblock change before suspend */
>>   	wait_event(mddev->sb_wait,
>> -		   conf->log == NULL ||
>> +		   rcu_access_pointer(conf->log) ||
> 
> Reversed condition?
> 
> I think, some examples in Documentation/RCU/Design/Requirements/Requirements.rst are reversed, too.

Oops. Nice Catch!

Thanks,

Logan