linux-kernel - Re: [RFC PATCH v2 3/7] objtool: Use target file class size instead of a compiled constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yo0dHcq7VYlt79nj@hirez.programming.kicks-ass.net>
Date:   Tue, 24 May 2022 19:59:57 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>, aik@...abs.ru,
        sv@...ux.ibm.com, rostedt@...dmis.org, jpoimboe@...hat.com,
        naveen.n.rao@...ux.vnet.ibm.com, mbenes@...e.cz,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [RFC PATCH v2 3/7] objtool: Use target file class size instead
 of a compiled constant

On Tue, May 24, 2022 at 03:17:43PM +0200, Christophe Leroy wrote:
> -	sec = elf_create_section(elf, relocname, 0, sizeof(GElf_Rela), 0);
> +	if (size == sizeof(u32))
> +		sec = elf_create_section(elf, relocname, 0, sizeof(Elf32_Rela), 0);
> +	else
> +		sec = elf_create_section(elf, relocname, 0, sizeof(GElf_Rela), 0);

Probably best to use Elf64_* here instead of GElf_*.