linux-kernel - Re: [PATCH] ext4: add KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yo6CmMYr2vBBO+Ks@mit.edu>
Date:   Wed, 25 May 2022 15:25:12 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Joe Perches <joe@...ches.com>
Cc:     Yu Zhe <yuzhe@...china.com>, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        liqiong@...china.com
Subject: Re: [PATCH] ext4: add KERN_<LEVEL> for printk()

On Wed, May 25, 2022 at 08:18:22AM -0700, Joe Perches wrote:
> On Wed, 2022-05-25 at 05:48 -0700, Yu Zhe wrote:
> > printk() should include KERN_<LEVEL> facility level, add them.
> 
> NACK.
> 
> checkpatch is just a guide.

checkpatch-only patches are something which I will tend to just
ignore.  (Even if the changes are correct, which they are not in this
case).

In addition to all of the other reasons why such drive-by checkpatch
patches are frowned upon, I would appreciate it if the code paths that
are changed are actually *tested*, at which point you might have
noticed that your changes werenn't doing the right thing.

(BTW I'll also note that the code involved that is almost never
enabled --- the developer would need to manually insert a "#define
DX_DEBUG" at the beginning of the fs/ext4/namei.c source file for the
code to be enabled.  It's only intended to be used by developers who
are doing surgery to the htree code.)

					- Ted