[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220525053814.3265216-1-irogers@google.com>
Date: Tue, 24 May 2022 22:38:11 -0700
From: Ian Rogers <irogers@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Kan Liang <kan.liang@...ux.intel.com>,
Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
Sandipan Das <sandipan.das@....com>,
Claire Jensen <cjense@...gle.com>, Alyssa Ross <hi@...ssa.is>,
Like Xu <likexu@...cent.com>,
James Clark <james.clark@....com>,
Florian Fischer <florian.fischer@...q.space>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
Claire Jensen <clairej735@...il.com>
Cc: Stephane Eranian <eranian@...gle.com>,
Ian Rogers <irogers@...gle.com>
Subject: [PATCH v4 0/3] JSON output for perf stat
Parsing the CSV or text output of perf stat can be problematic when
new output is added (columns in CSV format). JSON names values and
simplifies the job of parsing. Add a JSON output option to perf-stat
then add unit test that parses and validates the output.
This is a resend of two v2 patches:
https://lore.kernel.org/lkml/20210813220754.2104922-1-cjense@google.com/
https://lore.kernel.org/lkml/20210813220936.2105426-1-cjense@google.com/
with a few formatting changes and improvements to the linter.
The CSV test/linter is also added to ensure that CSV output doesn't regress:
https://lore.kernel.org/lkml/20210813192108.2087512-1-cjense@google.com/
v4. Does some minor fixes to the json linter.
v3. There is some tidy up of CSV code including a potential memory
over run in the os.nfields set up caught by sanitizers. To
facilitate this an AGGR_MAX value is added. v3 also adds the CSV
testing.
v2. Fixes the system wide no aggregation test to not run if the
paranoia is wrong. It also makes the counter-value check handle
the "<not counted>" and "<not supported>" cases.
Claire Jensen (3):
perf test: Add checking for perf stat CSV output.
perf stat: Add JSON output option
perf test: Json format checking
tools/perf/Documentation/perf-stat.txt | 21 +
tools/perf/builtin-stat.c | 6 +
.../tests/shell/lib/perf_csv_output_lint.py | 48 +++
.../tests/shell/lib/perf_json_output_lint.py | 94 +++++
tools/perf/tests/shell/stat+csv_output.sh | 147 +++++++
tools/perf/tests/shell/stat+json_output.sh | 147 +++++++
tools/perf/util/stat-display.c | 384 +++++++++++++-----
tools/perf/util/stat.c | 1 +
tools/perf/util/stat.h | 2 +
9 files changed, 744 insertions(+), 106 deletions(-)
create mode 100644 tools/perf/tests/shell/lib/perf_csv_output_lint.py
create mode 100644 tools/perf/tests/shell/lib/perf_json_output_lint.py
create mode 100755 tools/perf/tests/shell/stat+csv_output.sh
create mode 100755 tools/perf/tests/shell/stat+json_output.sh
--
2.36.1.124.g0e6072fb45-goog
Powered by blists - more mailing lists