linux-kernel - Re: [PATCH -next] serial: pic32: fix missing clk_disable_unprepare() on error in pic32_uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a3246cd-9edb-659f-8332-df7bcce3c13a@kernel.org>
Date:   Wed, 25 May 2022 07:49:48 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Cc:     gregkh@...uxfoundation.org
Subject: Re: [PATCH -next] serial: pic32: fix missing clk_disable_unprepare()
 on error in pic32_uart_startup()

On 25. 05. 22, 4:12, Yang Yingliang wrote:
> Fix the missing clk_disable_unprepare() before return
> from pic32_uart_startup() in the error handling case.
> 
> Fixes: 157b9394709e ("serial: pic32_uart: Add PIC32 UART driver")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>


Reviewed-by: Jiri Slaby <jirislaby@...nel.org>


> ---
>   drivers/tty/serial/pic32_uart.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c
> index b399aac530fe..f418f1de66b3 100644
> --- a/drivers/tty/serial/pic32_uart.c
> +++ b/drivers/tty/serial/pic32_uart.c
> @@ -503,7 +503,7 @@ static int pic32_uart_startup(struct uart_port *port)
>   	if (!sport->irq_fault_name) {
>   		dev_err(port->dev, "%s: kasprintf err!", __func__);
>   		ret = -ENOMEM;
> -		goto out_done;
> +		goto out_disable_clk;
>   	}
>   	irq_set_status_flags(sport->irq_fault, IRQ_NOAUTOEN);
>   	ret = request_irq(sport->irq_fault, pic32_uart_fault_interrupt,
> @@ -579,6 +579,8 @@ static int pic32_uart_startup(struct uart_port *port)
>   out_f:
>   	free_irq(sport->irq_fault, port);
>   	kfree(sport->irq_fault_name);
> +out_disable_clk:
> +	clk_disable_unprepare(sport->clk);
>   out_done:
>   	return ret;
>   }


-- 
js
suse labs