linux-kernel - Re: [PATCH] iio: srf08: Remove redundant if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 May 2022 08:33:38 +0200
From:   Andreas Klinger <ak@...klinger.de>
To:     Li Zhengyu <lizhengyu3@...wei.com>
Cc:     jic23@...nel.org, lars@...afoo.de, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: srf08: Remove redundant if statement

Acked-by: Andreas Klinger <ak@...klinger.de>

Li Zhengyu <lizhengyu3@...wei.com> schrieb am Mo, 23. Mai 20:27:
> (!val) has been checked outside the loop, remove redundant (val &&)
> from loop.
> 
> Signed-off-by: Li Zhengyu <lizhengyu3@...wei.com>
> ---
>  drivers/iio/proximity/srf08.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> index ac1ab7e89d4e..7ed11339c31e 100644
> --- a/drivers/iio/proximity/srf08.c
> +++ b/drivers/iio/proximity/srf08.c
> @@ -354,7 +354,7 @@ static ssize_t srf08_write_sensitivity(struct srf08_data *data,
>  		return -EINVAL;
>  
>  	for (i = 0; i < data->chip_info->num_sensitivity_avail; i++)
> -		if (val && (val == data->chip_info->sensitivity_avail[i])) {
> +		if (val == data->chip_info->sensitivity_avail[i]) {
>  			regval = i;
>  			break;
>  		}
> -- 
> 2.17.1
> 

-- 
Andreas Klinger
Grabenreith 27
84508 Burgkirchen
+49 8623 919966
ak@...klinger.de
www.it-klinger.de
www.grabenreith.de