linux-kernel - Re: [PATCH net] net/smc: set ini->smcrv2.ib_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29c0ef74-27d9-b8a4-623d-770b36e488b6@linux.ibm.com>
Date:   Wed, 25 May 2022 11:10:52 +0200
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     liuyacan@...p.netease.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc:     linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ubraun@...ux.ibm.com
Subject: Re: [PATCH net] net/smc: set ini->smcrv2.ib_dev_v2 to NULL if SMC-Rv2
 is unavailable

On 25/05/2022 10:54, liuyacan@...p.netease.com wrote:
> From: liuyacan <liuyacan@...p.netease.com>
> 
> In the process of checking whether RDMAv2 is available, the current
> implementation first sets ini->smcrv2.ib_dev_v2, and then allocates
> smc buf desc and register rmb, but the latter may fail. In this case,
> the pointer should be reset.
> 
> Fixes: e49300a6bf62 ("net/smc: add listen processing for SMC-Rv2")
> Signed-off-by: liuyacan <liuyacan@...p.netease.com>
> ---
>  net/smc/af_smc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 45a24d242..540b32d86 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -2136,6 +2136,7 @@ static void smc_find_rdma_v2_device_serv(struct smc_sock *new_smc,
>  
>  not_found:
>  	ini->smcr_version &= ~SMC_V2;
> +	ini->smcrv2.ib_dev_v2 = NULL;
>  	ini->check_smcrv2 = false;
>  }
>  

Thank you!

Reviewed-by: Karsten Graul <kgraul@...ux.ibm.com>