linux-kernel - Re: Getting rid of infradead.org

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 May 2022 10:55:18 +0100
From:   David Woodhouse <dwmw2@...radead.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        mark@...piro.net
Cc:     workflows@...r.kernel.org,
        Konstantin Ryabitsev <konstantin@...uxfoundation.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        MTD Maling List <linux-mtd@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Subject: Re: Getting rid of infradead.org - corrupted subjects

On Wed, 2022-05-25 at 10:34 +0200, Geert Uytterhoeven wrote:
> CC dwmw2

Thanks, Geert.

> On Wed, May 25, 2022 at 10:07 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
> 
> > The address list is semi-random as I don't know whom to approach.
> > Problem: infradead.org corrupts email subjects by changing:
> > s/,/, /

I found an old thread on mailman-users which appears to be claiming
that it's just standard folding as described in RFC2822 §2.2.3.

https://mail.python.org/pipermail/mailman-users/2007-May/057119.html

2.2.3. Long Header Fields

   Each header field is logically a single line of characters comprising
   the field name, the colon, and the field body.  For convenience
   however, and to deal with the 998/78 character limitations per line,
   the field body portion of a header field can be split into a multiple
   line representation; this is called "folding".  The general rule is
   that wherever this standard allows for folding white space (not
   simply WSP characters), a CRLF may be inserted before any WSP.  For
   example, the header field:

           Subject: This is a test

   can be represented as:

           Subject: This
            is a test

But this is folding at a *comma*, not at whitespace. The original
subject line was (in a single line):

Subject: [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties

... and Mailman 'folded' it in the wrong place to:

Subject: [PATCH v2] dt-bindings: mtd: jedec,
 spi-nor: remove unneeded properties

That *isn't* proper folding because it didn't happen at a whitespace.

I do need to upgrade to Mailman 3 at some point; I've been
procrastinating on the basis that it "ain't broke". For the time being
I've just disabled folding in MM2 with a trivial hack:

--- Message.py.orig	2022-05-25 02:51:05.917145192 -0700
+++ Message.py	2022-05-25 02:50:44.137142069 -0700
@@ -49,7 +49,7 @@ class Generator(email.Generator.Generato
        Headers will by default _not_ be folded in attachments.
     """
     def __init__(self, outfp, mangle_from_=True,
-                 maxheaderlen=78, children_maxheaderlen=0):
+                 maxheaderlen=0, children_maxheaderlen=0):
         email.Generator.Generator.__init__(self, outfp,
                 mangle_from_=mangle_from_, maxheaderlen=maxheaderlen)
         self.__children_maxheaderlen = children_maxheaderlen

Looking at http://lists.infradead.org/pipermail/testlist/2022-May/subject.html
it seems to have had the desired effect. Please let me know if not (or
if there are other side-effects).

Thanks for the report.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)