linux-kernel - Re: [PATCH] xen: remove setting of 'transp' parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10ce14c0-f502-4c26-3f7a-8f470822e6f3@gmx.de>
Date:   Wed, 25 May 2022 14:17:39 +0200
From:   Helge Deller <deller@....de>
To:     Tom Rix <trix@...hat.com>, tzimmermann@...e.de, javierm@...hat.com,
        boris.ostrovsky@...cle.com, jgross@...e.com
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen: remove setting of 'transp' parameter

On 5/21/22 21:59, Tom Rix wrote:
> cppcheck reports
> [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
>
> The value parameter 'transp' is not used, so setting it can be removed.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

applied to the fbdev tree.
Thanks!
Helge

> ---
>  drivers/video/fbdev/xen-fbfront.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index 3bed357a9870..4d2694d904aa 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
>  	red = CNVT_TOHW(red, info->var.red.length);
>  	green = CNVT_TOHW(green, info->var.green.length);
>  	blue = CNVT_TOHW(blue, info->var.blue.length);
> -	transp = CNVT_TOHW(transp, info->var.transp.length);
>  #undef CNVT_TOHW
>
>  	v = (red << info->var.red.offset) |