[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220525151517.8430-1-mkoutny@suse.com>
Date: Wed, 25 May 2022 17:15:15 +0200
From: Michal Koutný <mkoutny@...e.com>
To: cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>,
Johannes Weiner <hannes@...xchg.org>,
Bui Quang Minh <minhquangbui99@...il.com>,
Tadeusz Struk <tadeusz.struk@...aro.org>
Subject: [PATCH 0/2] cgroup_subsys_state lifecycle fixups
Two corner cases were hanging around [2][3] related to css lifecycles,
since they're loosely related I'm sending them together.
The 2nd patch fixes problems encountered in syzbot tests only.
Alternative solutions could be:
- daisy-chain css_release_work_fn from the offending css_killed_work_fn call,
- rework kill_css() not to rely on multi-stage css_killed_work_fn() [1].
The simplest approach was chosen.
The other existing users of percpu_ref_kill_and_confirm are not affected by
similar issues.
[1] Rough idea is to only synchronize via a completion like e.g.
nvmet_sq_destroy() does and move most of css_killed_work_fn() at the end of
kill_css(). kill_css() is only used in process context when de-configuring
controllers or rmdiring a cgroup.
[2] https://lore.kernel.org/lkml/20220404142535.145975-1-minhquangbui99@gmail.com/
[3] https://lore.kernel.org/lkml/20220412192459.227740-1-tadeusz.struk@linaro.org/
Michal Koutný (2):
cgroup: Wait for cgroup_subsys_state offlining on unmount
cgroup: Use separate work structs on css release path
include/linux/cgroup-defs.h | 5 +++--
kernel/cgroup/cgroup.c | 19 +++++++++++--------
2 files changed, 14 insertions(+), 10 deletions(-)
--
2.35.3
Powered by blists - more mailing lists