[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220525112551.37e86da6@gandalf.local.home>
Date: Wed, 25 May 2022 11:25:51 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Gautam Menghani <gautammenghani201@...il.com>
Cc: mingo@...hat.com, linux-kernel@...r.kernel.org,
linux-kernel-mentees@...ts.linuxfoundation.org,
skhan@...uxfoundation.org, Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] kernel/trace: Initialize integer variable to prevent
garbage return value
On Sat, 21 May 2022 23:18:26 -0700
Gautam Menghani <gautammenghani201@...il.com> wrote:
> Initialize the integer variable to 0 to fix the clang scan warning:
> Undefined or garbage value returned to caller
> [core.uninitialized.UndefReturn]
> return ret;
>
> Signed-off-by: Gautam Menghani <gautammenghani201@...il.com>
> ---
> kernel/trace/trace_boot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> index 0580287d7a0d..778200dd8ede 100644
> --- a/kernel/trace/trace_boot.c
> +++ b/kernel/trace/trace_boot.c
> @@ -300,7 +300,7 @@ trace_boot_hist_add_handlers(struct xbc_node *hnode, char **bufp,
> {
> struct xbc_node *node;
> const char *p, *handler;
> - int ret;
> + int ret = 0;
Looks good to me. Masami, care to ack it?
-- Steve
>
> handler = xbc_node_get_data(hnode);
>
Powered by blists - more mailing lists