linux-kernel - Re: [PATCH v3 5/5] selftests: memcg: Factor out common parts of memory.{low,min} tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yo2TvWr/0Y6s9SE2@carbon>
Date:   Tue, 24 May 2022 19:26:05 -0700
From:   Roman Gushchin <roman.gushchin@...ux.dev>
To:     Michal Koutný <mkoutny@...e.com>
Cc:     cgroups@...r.kernel.org, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Richard Palethorpe <rpalethorpe@...e.de>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>
Subject: Re: [PATCH v3 5/5] selftests: memcg: Factor out common parts of
 memory.{low,min} tests

On Tue, May 24, 2022 at 06:29:55PM +0200, Michal Koutny wrote:
> The memory protection test setup and runtime is almost equal for
> memory.low and memory.min cases.
> It makes modification of the common parts prone to mistakes, since the
> protections are similar not only in setup but also in principle, factor
> the common part out.
> 
> Past exceptions between the tests:
> - missing memory.min is fine (kept),
> - test_memcg_low protected orphaned pagecache (adapted like
>   test_memcg_min and we keep the processes of protected memory running).
> 
> The evaluation in two tests is different (OOM of allocator vs low events
> of protégés), this is kept different.
> 
> Signed-off-by: Michal Koutný <mkoutny@...e.com>

Acked-by: Roman Gushchin <roman.gushchin@...ux.dev>