[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6e3cdf37-299a-98df-1143-c3392e9acec0@linuxfoundation.org>
Date: Wed, 25 May 2022 10:05:12 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Meng Li <li.meng@....com>, Huang Rui <ray.huang@....com>,
linux-pm@...r.kernel.org
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
Nathan Fontenot <nathan.fontenot@....com>,
Deepak Sharma <deepak.sharma@....com>,
Alex Deucher <alexander.deucher@....com>,
Mario Limonciello <mario.limonciello@....com>,
Jinzhou Su <Jinzhou.Su@....com>,
Perry Yuan <Perry.Yuan@....com>,
Xiaojian Du <Xiaojian.Du@....com>,
Viresh Kumar <viresh.kumar@...aro.org>,
Borislav Petkov <bp@...en8.de>, linux-kernel@...r.kernel.org,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH V7 2/4] cpufreq: amd-pstate: Add test module for
amd-pstate driver
On 5/22/22 5:54 AM, Meng Li wrote:
> Add amd-pstate-ut module, which is conceptually out-of-tree module
I didn't notice this before. Let's get rid of "out-of-tree" workding.
> and provides ways for selftests/amd-pstate driver to test various
> kernel module-related functionality. This module will be expected by
> some of selftests to be present and loaded.
>
What does "various kernel module-related functionality" mean. Can we
rephrase this to say "this module is used by kselftest to unit test
amd-pstate functionality" ?
> Signed-off-by: Meng Li <li.meng@....com>
> Acked-by: Huang Rui <ray.huang@....com>
> ---
[snip]
> +
> +module_init(amd_pstate_ut_init);
> +module_exit(amd_pstate_ut_exit);
> +
> +MODULE_AUTHOR("Meng Li <li.meng@....com>");
> +MODULE_DESCRIPTION("Kselftest for AMD P-state driver");
Change this to "AMD P-state driver Test module"
Having Kselftest in the name is confusing. It is a test driver
that kselftest amd_pstate_test depends on.
> +MODULE_LICENSE("GPL");
>
With these above changes:
Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
thanks,
-- Shuah
Powered by blists - more mailing lists