linux-kernel - Re: [GIT PULL] first round of SCSI updates for the 5.18+ merge window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wh5SyuAox3QXvmJLwV4VgN_EK4oaAkh5-73FVf36ZdHog@mail.gmail.com>
Date:   Wed, 25 May 2022 19:17:38 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     James Bottomley <James.Bottomley@...senpartnership.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] first round of SCSI updates for the 5.18+ merge window

On Tue, May 24, 2022 at 7:38 PM James Bottomley
<James.Bottomley@...senpartnership.com> wrote:
>
> Max Gurtovoy (3):
>       scsi: target: iscsi: Rename iscsi_session to iscsit_session
>       scsi: target: iscsi: Rename iscsi_conn to iscsit_conn
>       scsi: target: iscsi: Rename iscsi_cmd to iscsit_cmd

People, there really isn't some incredible drought of letters in the
world. It's ok to write out "target" instead of just "t".

Done is done, and renaming things further is probably not worth it,
but when the commit talks about "more readable code" I really don't
know if "struct iscsit_session" and friends is conducive to "more
readable". It looks more like line noise.

Yeah, it's less typing, and maybe "struct iscsi_target_session" would
have been too long. But still, I had to do a double-take when looking
at the diff, and aside from it being line noise, having a structure
name that differs by just one character in the middle between target
and initiator feels like mistake.

Anyway, pulled despite what feels like an oddity.

                Linus