linux-kernel - Re: [PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b66103c7-6363-82dc-1e06-a1071b3aa19b@roeck-us.net>
Date:   Wed, 25 May 2022 19:23:10 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Rob Herring <robh@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Corentin Labbe <clabbe@...libre.com>
Cc:     linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: faraday: Fix typo in example
 'timeout-sec' property

On 5/25/22 18:41, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
> 
> The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

Good find.

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   .../devicetree/bindings/watchdog/faraday,ftwdt010.yaml          | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> index ca9e1beff76b..6ecd429f76b5 100644
> --- a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> @@ -55,7 +55,7 @@ examples:
>         compatible = "faraday,ftwdt010";
>         reg = <0x41000000 0x1000>;
>         interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> -      timeout-secs = <5>;
> +      timeout-sec = <5>;
>       };
>     - |
>       watchdog: watchdog@...00000 {