linux-kernel - Re: [PATCH v3 2/4] soc: mediatek: svs: add support for mt8186

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48e3f8a9db7b4fe429ed55440b8fa437f40b12ba.camel@mediatek.com>
Date:   Thu, 26 May 2022 13:52:00 +0800
From:   Jia-Wei Chang <jia-wei.chang@...iatek.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Roger Lu <roger.lu@...iatek.com>,
        Kevin Hilman <khilman@...nel.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        <hsinyi@...gle.com>
Subject: Re: [PATCH v3 2/4] soc: mediatek: svs: add support for mt8186

On Mon, 2022-05-23 at 11:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 23/05/22 10:40, Tim Chang ha scritto:
> > From: Jia-Wei Chang <jia-wei.chang@...iatek.com>
> > 
> > MT8186 svs has a number of banks which used as optimization of opp
> > voltage table for corresponding dvfs drivers.
> > MT8186 svs big core uses 2-line high bank and low bank to optimize
> > the
> > voltage of opp table for higher and lower frequency respectively.
> > 
> > Signed-off-by: Jia-Wei Chang <jia-wei.chang@...iatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@...labora.com>
> > ---
> >   drivers/soc/mediatek/mtk-svs.c | 351
> > ++++++++++++++++++++++++++++++++-
> >   1 file changed, 344 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/soc/mediatek/mtk-svs.c
> > b/drivers/soc/mediatek/mtk-svs.c
> > index 606a00a2e57d..656d0361ff7d 100644
> > --- a/drivers/soc/mediatek/mtk-svs.c
> > +++ b/drivers/soc/mediatek/mtk-svs.c
> 
> ..snip..
> 
> > @@ -2245,6 +2569,16 @@ static const struct svs_platform_data
> > svs_mt8192_platform_data = {
> >   	.bank_max = ARRAY_SIZE(svs_mt8192_banks),
> >   };
> >   
> > +static const struct svs_platform_data svs_mt8186_platform_data = {
> > +	.name = "mt8186-svs",
> > +	.banks = svs_mt8186_banks,
> > +	.efuse_parsing = svs_mt8186_efuse_parsing,
> > +	.probe = svs_mt8186_platform_probe,
> > +	.irqflags = IRQF_TRIGGER_HIGH,
> 
> I know I gave you my R-b tag earlier, but I've just noticed that:
> please remove
> irqflags, as this kind of flags are specified in devicetree and it is
> not
> necessary to specify them here.
> 
> Thanks,
> Angelo

Hi Angelo,

Sure, I will remove it in the next version.
Thanks.