linux-kernel - [ebiggers:f2fs-pending 1/1] fs/f2fs/super.c:520:28: error: implicit declaration of function 'fscrypt_is_dummy_policy_set'; did you mean 'fscrypt_free_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202205261426.lSpXReh7-lkp@intel.com>
Date:   Thu, 26 May 2022 14:41:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     Eric Biggers <ebiggers@...gle.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [ebiggers:f2fs-pending 1/1] fs/f2fs/super.c:520:28: error: implicit
 declaration of function 'fscrypt_is_dummy_policy_set'; did you mean
 'fscrypt_free_dummy_policy'?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git f2fs-pending
head:   14c933f493ea41e28bbe5317af611dc01d66b489
commit: 14c933f493ea41e28bbe5317af611dc01d66b489 [1/1] f2fs: use the updated test_dummy_encryption helper functions
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220526/202205261426.lSpXReh7-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/commit/?id=14c933f493ea41e28bbe5317af611dc01d66b489
        git remote add ebiggers https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
        git fetch --no-tags ebiggers f2fs-pending
        git checkout 14c933f493ea41e28bbe5317af611dc01d66b489
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/f2fs/super.c: In function 'f2fs_set_test_dummy_encryption':
>> fs/f2fs/super.c:520:28: error: implicit declaration of function 'fscrypt_is_dummy_policy_set'; did you mean 'fscrypt_free_dummy_policy'? [-Werror=implicit-function-declaration]
     520 |         if (is_remount && !fscrypt_is_dummy_policy_set(policy)) {
         |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                            fscrypt_free_dummy_policy
>> fs/f2fs/super.c:525:15: error: implicit declaration of function 'fscrypt_parse_test_dummy_encryption'; did you mean 'fscrypt_set_test_dummy_encryption'? [-Werror=implicit-function-declaration]
     525 |         err = fscrypt_parse_test_dummy_encryption(&param, policy);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |               fscrypt_set_test_dummy_encryption
>> fs/f2fs/super.c:538:15: error: implicit declaration of function 'fscrypt_add_test_dummy_key' [-Werror=implicit-function-declaration]
     538 |         err = fscrypt_add_test_dummy_key(sb, policy);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +520 fs/f2fs/super.c

   489	
   490	static int f2fs_set_test_dummy_encryption(struct super_block *sb,
   491						  const char *opt,
   492						  const substring_t *arg,
   493						  bool is_remount)
   494	{
   495		struct f2fs_sb_info *sbi = F2FS_SB(sb);
   496		struct fs_parameter param = {
   497			.type = fs_value_is_string,
   498			.string = arg->from ? arg->from : "",
   499		};
   500		struct fscrypt_dummy_policy *policy =
   501			&F2FS_OPTION(sbi).dummy_enc_policy;
   502		int err;
   503	
   504		if (!IS_ENABLED(CONFIG_FS_ENCRYPTION)) {
   505			f2fs_warn(sbi, "test_dummy_encryption option not supported");
   506			return -EINVAL;
   507		}
   508	
   509		if (!f2fs_sb_has_encrypt(sbi)) {
   510			f2fs_err(sbi, "Encrypt feature is off");
   511			return -EINVAL;
   512		}
   513	
   514		/*
   515		 * This mount option is just for testing, and it's not worthwhile to
   516		 * implement the extra complexity (e.g. RCU protection) that would be
   517		 * needed to allow it to be set or changed during remount.  We do allow
   518		 * it to be specified during remount, but only if there is no change.
   519		 */
 > 520		if (is_remount && !fscrypt_is_dummy_policy_set(policy)) {
   521			f2fs_warn(sbi, "Can't set test_dummy_encryption on remount");
   522			return -EINVAL;
   523		}
   524	
 > 525		err = fscrypt_parse_test_dummy_encryption(&param, policy);
   526		if (err) {
   527			if (err == -EEXIST)
   528				f2fs_warn(sbi,
   529					  "Can't change test_dummy_encryption on remount");
   530			else if (err == -EINVAL)
   531				f2fs_warn(sbi, "Value of option \"%s\" is unrecognized",
   532					  opt);
   533			else
   534				f2fs_warn(sbi, "Error processing option \"%s\" [%d]",
   535					  opt, err);
   536			return -EINVAL;
   537		}
 > 538		err = fscrypt_add_test_dummy_key(sb, policy);
   539		if (err) {
   540			f2fs_warn(sbi, "Error adding test dummy encryption key [%d]",
   541				  err);
   542			return err;
   543		}
   544		f2fs_warn(sbi, "Test dummy encryption mode enabled");
   545		return 0;
   546	}
   547	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp