linux-kernel - Re: [PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13a92f37-2491-9daa-05a7-f831d9bbb0e0@microchip.com>
Date:   Thu, 26 May 2022 06:52:23 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <robh@...nel.org>, <broonie@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>
CC:     <krzysztof.kozlowski@...aro.org>, <linux-spi@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in
 examples

On 26/05/2022 02:41, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
> 
> 'spi-max-frequency' is supposed to be a per SPI peripheral device property,
> not a SPI controller property, so drop it.

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

As this property is in the mpfs devicetree & I'll need to fix it, is this
patch targeted at 5.19? (I assume given the window is open and there's no
fixes tag that it isn't).

As an aside, I meant to send the driver once the merge window closes, so
thanks for spotting a problem with the driver before I even sent it :)

Thanks,
Conor.

> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>   Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml | 1 -
>   Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index ece261b8e963..7326c0a28d16 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -47,6 +47,5 @@ examples:
>           clocks = <&clkcfg CLK_SPI0>;
>           interrupt-parent = <&plic>;
>           interrupts = <54>;
> -        spi-max-frequency = <25000000>;
>       };
>   ...
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> index e2c7b934c50d..78ceb9d67754 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> @@ -110,7 +110,6 @@ examples:
>           pinctrl-names = "default";
>           pinctrl-0 = <&qup_spi1_default>;
>           interrupts = <GIC_SPI 602 IRQ_TYPE_LEVEL_HIGH>;
> -        spi-max-frequency = <50000000>;
>           #address-cells = <1>;
>           #size-cells = <0>;
>       };
> --
> 2.34.1
>