linux-kernel - [PATCH] ARM: integrator: Fix refcount leak in intcp_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220526081756.32998-1-linmq006@gmail.com>
Date:   Thu, 26 May 2022 12:17:56 +0400
From:   Miaoqian Lin <linmq006@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     linmq006@...il.com
Subject: [PATCH] ARM: integrator: Fix refcount leak in intcp_init_of

of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: df36680f1a71 ("ARM: integrator: core module registers from compatible strings")
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
---
 arch/arm/mach-integrator/integrator_cp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-integrator/integrator_cp.c b/arch/arm/mach-integrator/integrator_cp.c
index b7eb4038798b..bb301ca8c7e1 100644
--- a/arch/arm/mach-integrator/integrator_cp.c
+++ b/arch/arm/mach-integrator/integrator_cp.c
@@ -126,6 +126,7 @@ static void __init intcp_init_of(void)
 		return;
 
 	intcp_con_base = of_iomap(cpcon, 0);
+	of_node_put(cpcon);
 	if (!intcp_con_base)
 		return;
 
-- 
2.25.1