linux-kernel - [PATCH] scsi: be2iscsi: fix potential memory leak in beiscsi_process_mcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 26 May 2022 16:57:21 +0800
From:   Jianglei Nie <niejianglei2021@....com>
To:     ketan.mukadam@...adcom.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jianglei Nie <niejianglei2021@....com>
Subject: [PATCH] scsi: be2iscsi: fix potential memory leak in beiscsi_process_mcc_compl()

We should call free_mcc_wrb() before the function returns.This patch
adds the missing free_mcc_wrb() before the funciton returns.

Signed-off-by: Jianglei Nie <niejianglei2021@....com>
---
 drivers/scsi/be2iscsi/be_cmds.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 69b1a80e3687..d07107a0bf41 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi/be_cmds.c
@@ -498,6 +498,7 @@ int beiscsi_process_mcc_compl(struct be_ctrl_info *ctrl,
 		beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_MBOX |
 			    BEISCSI_LOG_INIT | BEISCSI_LOG_CONFIG,
 			    "BC_%d : MBX cmd completed but not posted\n");
+		free_mcc_wrb(ctrl, tag);
 		return 0;
 	}
 
-- 
2.25.1