linux-kernel - Re: [PATCH] soc: bcm: brcmstb: pm: pm-arm: Fix refcount leak in brcmstb_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 May 2022 14:21:35 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Broadcom Kernel Team <bcm-kernel-feedback-list@...adcom.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Kees Cook <keescook@...omium.org>,
        Helge Deller <deller@....de>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Gareth Powell <gpowell@...adcom.com>,
        Brian Norris <computersforpeace@...il.com>,
        Doug Berger <opendmb@...il.com>,
        Justin Chen <justinpopo6@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: bcm: brcmstb: pm: pm-arm: Fix refcount leak in
 brcmstb_pm_probe

On Thu, May 26, 2022 at 11:53:22AM +0400, Miaoqian Lin wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
> 
> In brcmstb_init_sram, it pass dn to of_address_to_resource(),
> of_address_to_resource() will call of_find_device_by_node() to take
> reference, so we should release the reference returned by
> of_find_matching_node().

Looks legit,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
>  drivers/soc/bcm/brcmstb/pm/pm-arm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c
> index 3cbb165d6e30..70ad0f3dce28 100644
> --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c
> +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c
> @@ -783,6 +783,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev)
>  	}
>  
>  	ret = brcmstb_init_sram(dn);
> +	of_node_put(dn);
>  	if (ret) {
>  		pr_err("error setting up SRAM for PM\n");
>  		return ret;
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko