linux-kernel - Re: [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a6b4mo1b.wl-maz@kernel.org>
Date:   Thu, 26 May 2022 14:17:04 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init

On Thu, 26 May 2022 08:43:48 +0100,
Miaoqian Lin <linmq006@...il.com> wrote:
> 
> of_find_matching_node_and_match() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Instead of sending these one after the other, why don't you send a
series addressing the irqchip drivers in one go? That'd be much easier
to manage and review.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.