linux-kernel - Re: [PATCH v7 2/5] x86/tdx: Add TDX Guest event notify interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffe3ab74-4258-cf54-86df-c2db5aa06504@linux.intel.com>
Date:   Thu, 26 May 2022 07:45:34 -0700
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Wander Lairson Costa <wander@...hat.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H . Peter Anvin" <hpa@...or.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kai Huang <kai.huang@...el.com>,
        Isaku Yamahata <isaku.yamahata@...il.com>,
        marcelo.cerri@...onical.com, tim.gardner@...onical.com,
        khalid.elmously@...onical.com, philip.cox@...onical.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/5] x86/tdx: Add TDX Guest event notify interrupt
 support



On 5/26/22 6:48 AM, Wander Lairson Costa wrote:
> On Mon, May 23, 2022 at 09:05:14PM -0700, Kuppuswamy Sathyanarayanan wrote:
>>   
>> -#define LOCAL_TIMER_VECTOR		0xec
>> +#if IS_ENABLED(CONFIG_INTEL_TDX_GUEST)
>> +/* Vector on which TDX Guest event notification is delivered */
>> +#define TDX_GUEST_EVENT_NOTIFY_VECTOR	0xec
>> +#endif
> 
> We can simplify this a bit by removing the #if conditional without harm
> to the code.

In non TDX environment, we don't initialize this vector. It is similar
to definitions related to HYPERV or KVM which also use #if defined. So
followed the same format.

> 
>> +
>> +#define LOCAL_TIMER_VECTOR		0xeb
>>   
>>   #define NR_VECTORS			 256
>>   
> 

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer