linux-kernel - Re: [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220526143844.2d5c8741@gandalf.local.home>
Date:   Thu, 26 May 2022 14:38:44 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     sunliming <sunliming@...inos.cn>, mingo@...nel.org,
        linux-tip-commits@...r.kernel.org, dave.hansen@...ux.intel.com,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        kelulanainsley@...il.com
Subject: Re: [PATCH V2] x86/idt: traceponit.c: fix comment for irq vector
 tracepoints

On Thu, 26 May 2022 09:24:31 -0700
Dave Hansen <dave.hansen@...el.com> wrote:

> On 5/26/22 04:08, sunliming wrote:
> > 
> > diff --git a/arch/x86/kernel/tracepoint.c b/arch/x86/kernel/tracepoint.c
> > index fcfc077afe2d..065191022035 100644
> > --- a/arch/x86/kernel/tracepoint.c
> > +++ b/arch/x86/kernel/tracepoint.c
> > @@ -1,9 +1,6 @@
> >  // SPDX-License-Identifier: GPL-2.0
> >  /*
> > - * Code for supporting irq vector tracepoints.
> > - *
> >   * Copyright (C) 2013 Seiji Aguchi <seiji.aguchi@....com>
> > - *
> >   */
> >  #include <linux/jump_label.h>
> >  #include <linux/atomic.h>  
> 
> While I'm also generally careful about removing others' copyrights, Mr.
> Aguchi only touched this file once and all of the code from that one
> touch appears to be gone to me.  Shouldn't we just zap the whole comment?

Perhaps, but that's a different change than this is addressing. This is
only addressing fixing the comments about the removal of the code.

But looking at the history of this file. Seiji created it, but the only
code that remains in the file was mostly added by Thomas. The only lines
that Seiji has now is the whitespace and the brackets.

I would still have the removal of the copyright as a separate patch.

-- Steve