linux-kernel - Re: [PATCHv2 1/2] i2c: designware: introduce a custom scl recovery for SoCFPGA platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3dafa370-cd77-e3ba-a48b-2ca3674432ab@kernel.org>
Date:   Thu, 26 May 2022 14:08:55 -0500
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
        robh+dt@...nel.org, krzk+dt@...nel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCHv2 1/2] i2c: designware: introduce a custom scl recovery
 for SoCFPGA platforms



On 5/24/22 11:43, Andy Shevchenko wrote:
> On Tue, May 24, 2022 at 08:54:40AM -0500, Dinh Nguyen wrote:
>> The I2C pins on the SoCFPGA platforms do not go through a GPIO module,
>> thus cannot be recovered by the default method of by doing a GPIO access.
>> Only a reset of the I2C IP block can a recovery be successful.
> 
> Better now, but see my additional comments.
> 
> ...
> 
>> +	switch (dev->flags & MODEL_MASK) {
>> +	case MODEL_SOCFPGA:
>> +		rinfo->recover_bus = i2c_socfpga_scl_recovery;
>> +		break;
>> +	default:
>> +		rinfo->recover_bus = i2c_generic_scl_recovery;
>> +		break;
>> +	}
> 
>> +	adap->bus_recovery_info = rinfo;
> 
> Usually we do not assign the pointer while data structure is incomplete.
> That's said, please leave this line as it was.
> 
> On top of that, why you can't move the above switch to the place where old
> function was assigned?
> 

I have to put the switch statement before the call to 
devm_gpiod_get_optional(), otherwise the recover_bus function pointer 
will not get set.

Dinh