[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220526214549.GA315754-robh@kernel.org>
Date: Thu, 26 May 2022 16:45:49 -0500
From: Rob Herring <robh@...nel.org>
To: Sven Peter <sven@...npeter.dev>
Cc: Hector Martin <marcan@...can.st>,
Alyssa Rosenzweig <alyssa@...enzweig.io>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Mark Kettenis <kettenis@...nbsd.org>,
linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains'
property
On Thu, May 26, 2022 at 03:48:15PM +0200, Sven Peter wrote:
> Hi,
>
>
> On Thu, May 26, 2022, at 03:41, Rob Herring wrote:
> > The 'unevaluatedProperties' schema checks is not fully working and doesn't
> > catch some cases where there's a $ref to another schema. A fix is pending,
> > but results in new warnings in examples.
> >
> > The Apple PCIe host has 3 power domains at least according to the example.
> > Add the 'power-domains' property to the schema.
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> > Ideally, we'd define what each power domain is, but I don't know what
> > they are.
> > ---
>
> I think the example is just wrong (or outdated) and we only need a single
> power-domain for pcie.
>
> The hierarchy is ps_pcie_ref -> ps_apcie -> ps_apcie_gp and the pcie
> node then only depends on ps_apcie_gp.
Okay, I'll update the example and schema.
Powered by blists - more mailing lists