linux-kernel - drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:63 amdgpu_gem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 27 May 2022 23:17:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Thomas Zimmermann <tzimmermann@...e.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Christian König <christian.koenig@....com>
Subject: drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:63 amdgpu_gem_fault() warn:
 inconsistent indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7e284070abe53d448517b80493863595af4ab5f0
commit: 71df0368e9b66afeb1fdb92a88be1a98cc25f310 drm/amdgpu: Implement mmap as GEM object function
date:   1 year ago
config: arc-randconfig-m031-20220524 (https://download.01.org/0day-ci/archive/20220527/202205272322.o7pvBJIF-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:63 amdgpu_gem_fault() warn: inconsistent indenting

Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:824 amdgpu_gem_op_ioctl() warn: should 'robj->tbo.page_alignment << 14' be a 64 bit type?

vim +63 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

    44	
    45	static vm_fault_t amdgpu_gem_fault(struct vm_fault *vmf)
    46	{
    47		struct ttm_buffer_object *bo = vmf->vma->vm_private_data;
    48		struct drm_device *ddev = bo->base.dev;
    49		vm_fault_t ret;
    50		int idx;
    51	
    52		ret = ttm_bo_vm_reserve(bo, vmf);
    53		if (ret)
    54			return ret;
    55	
    56		if (drm_dev_enter(ddev, &idx)) {
    57			ret = amdgpu_bo_fault_reserve_notify(bo);
    58			if (ret) {
    59				drm_dev_exit(idx);
    60				goto unlock;
    61			}
    62	
  > 63			 ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
    64							TTM_BO_VM_NUM_PREFAULT, 1);
    65	
    66			 drm_dev_exit(idx);
    67		} else {
    68			ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
    69		}
    70		if (ret == VM_FAULT_RETRY && !(vmf->flags & FAULT_FLAG_RETRY_NOWAIT))
    71			return ret;
    72	
    73	unlock:
    74		dma_resv_unlock(bo->base.resv);
    75		return ret;
    76	}
    77	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp