linux-kernel - Re: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before the configuration data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02cbaf49474cbba446b6bdae77d5da950cce3e00.camel@ndufresne.ca>
Date:   Fri, 27 May 2022 15:26:13 -0400
From:   Nicolas Dufresne <nicolas@...fresne.ca>
To:     Ming Qian <ming.qian@....com>, Fabio Estevam <festevam@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Mirela Rabulea (OSS)" <mirela.rabulea@....nxp.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        linux-media <linux-media@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space
 before the configuration data

Le vendredi 27 mai 2022 à 11:33 +0000, Ming Qian a écrit :
> > From: Fabio Estevam <festevam@...il.com>
> > Sent: 2022年5月27日 19:12
> > To: Ming Qian <ming.qian@....com>
> > Cc: Mauro Carvalho Chehab <mchehab@...nel.org>; Mirela Rabulea (OSS)
> > <mirela.rabulea@....nxp.com>; Hans Verkuil <hverkuil-cisco@...all.nl>;
> > Shawn Guo <shawnguo@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>;
> > Sascha Hauer <kernel@...gutronix.de>; dl-linux-imx <linux-imx@....com>;
> > linux-media <linux-media@...r.kernel.org>; linux-kernel
> > <linux-kernel@...r.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED
> > DEVICE TREE BINDINGS <devicetree@...r.kernel.org>; moderated
> > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> > <linux-arm-kernel@...ts.infradead.org>
> > Subject: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before
> > the
> > configuration data
> > 
> > Caution: EXT Email
> > 
> > Hi Ming,
> > 
> > On Fri, May 27, 2022 at 7:25 AM Ming Qian <ming.qian@....com> wrote:
> > > 
> > > There is a hardware bug that it will load the first 128 bytes of
> > > configuration data twice, it will led to some configure error.
> > > so shift the configuration data 128 bytes, and make the first 128
> > > bytes all zero, then hardware will load the 128 zero twice, and ignore
> > > them as garbage.
> > > then the configuration data can be loaded correctly
> > > 
> > > Signed-off-by: Ming Qian <ming.qian@....com>
> > > Reviewed-by: Mirela Rabulea <mirela.rabulea@....com>
> > > Reviewed-by: Tommaso Merciai <tommaso.merciai@...rulasolutions.com>
> > 
> > Fixes tag?
> 
> Hi Fabio,
>     It's a hardware issue, so I'm not sure is it a driver issue that I fix it.
>     Or I just check which patch includes the code I changed, and add the fix
> tag?

You can use Fixes tag even though there was no software bug. The point of the
tag is to help locate how far we can backport this patch in order to let stable
kernel users benefit.

regards,
Nicolas

> 
> Ming