linux-kernel - Re: [PATCH v2] media: Hantro: Correct G2 init qp field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd8c9ef48b48e014c468fe8cf61cd44062d14b1d.camel@ndufresne.ca>
Date:   Fri, 27 May 2022 16:05:51 -0400
From:   Nicolas Dufresne <nicolas@...fresne.ca>
To:     Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        ezequiel@...guardiasur.com.ar, p.zabel@...gutronix.de,
        mchehab@...nel.org, gregkh@...uxfoundation.org
Cc:     linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: Hantro: Correct G2 init qp field

Le mardi 24 mai 2022 à 13:59 +0200, Benjamin Gaignard a écrit :
> Documentation said that g2 init_qp field use bits 24 to 30 of
> the 8th register.
> Change the field mask to be able to set 7 bits and not only 6 of them.
> 
> Conformance test INITQP_B_Main10_Sony_1 decoding is OK with this
> patch.
> 
> Fixes: cb5dd5a0fa518 ("media: hantro: Introduce G2/HEVC decoder")
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

> ---
> With this patch and the patches needed for 10-bit support
> Fluster HEVC score is 137/147
> 
> version 2:
> - Add Fixes tag
> 
>  drivers/staging/media/hantro/hantro_g2_regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/hantro/hantro_g2_regs.h b/drivers/staging/media/hantro/hantro_g2_regs.h
> index 877d663a8181..82606783591a 100644
> --- a/drivers/staging/media/hantro/hantro_g2_regs.h
> +++ b/drivers/staging/media/hantro/hantro_g2_regs.h
> @@ -107,7 +107,7 @@
>  
>  #define g2_start_code_e		G2_DEC_REG(10, 31, 0x1)
>  #define g2_init_qp_old		G2_DEC_REG(10, 25, 0x3f)
> -#define g2_init_qp		G2_DEC_REG(10, 24, 0x3f)
> +#define g2_init_qp		G2_DEC_REG(10, 24, 0x7f)
>  #define g2_num_tile_cols_old	G2_DEC_REG(10, 20, 0x1f)
>  #define g2_num_tile_cols	G2_DEC_REG(10, 19, 0x1f)
>  #define g2_num_tile_rows_old	G2_DEC_REG(10, 15, 0x1f)