linux-kernel - Re: [PATCH 1/2] [PATCH 1/2] mm: refactor of vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220527233915.55oe6jittuogavot@box.shutemov.name>
Date:   Sat, 28 May 2022 02:39:15 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Jakub Matěna <matenajakub@...il.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
        vbabka@...e.cz, mhocko@...nel.org, mgorman@...hsingularity.net,
        willy@...radead.org, liam.howlett@...cle.com, hughd@...gle.com,
        riel@...riel.com, rostedt@...dmis.org, peterz@...radead.org
Subject: Re: [PATCH 1/2] [PATCH 1/2] mm: refactor of vma_merge()

On Fri, May 27, 2022 at 12:48:09PM +0200, Jakub Matěna wrote:
> Refactor vma_merge() to make it shorter and more understandable.
> Main change is the elimination of code duplicity in the case of
> merge next check. This is done by first doing checks and caching
> the results before executing the merge itself. The variable 'area' is
> divided into 'mid' and 'res' as previously it was used for two purposes,
> as the middle VMA between prev and next and also as the result of the
> merge itself. Exit paths are also unified.
> 
> Signed-off-by: Jakub Matěna <matenajakub@...il.com>

You've ignored my ack. Or is there substantial changes that you want me to
review again?

-- 
 Kirill A. Shutemov