lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 May 2022 09:10:07 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Yu Zhe <yuzhe@...china.com> Cc: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com, vincent.guittot@...aro.org, dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, liqiong@...china.com Subject: Re: [PATCH] sched: change printk(KERN_<LEVEL>.. to pr_<level>() On Thu, May 26, 2022 at 02:10:31AM -0700, Yu Zhe wrote: > @@ -9370,7 +9370,7 @@ static void dump_rq_tasks(struct rq *rq, const char *loglvl) > > lockdep_assert_rq_held(rq); > > - printk("%sCPU%d enqueued tasks (%u total):\n", loglvl, cpu, rq->nr_running); > + pr_warn("%sCPU%d enqueued tasks (%u total):\n", loglvl, cpu, rq->nr_running); ^^^^^^ Your patch is wrong. The code aready has loglvl but as a variable. Don't start sending checkpatch stuff to kernel/sched. Better to get some experience in drivers/staging/ because Greg deliberately leaves a lot of garbage code for people to clean up and get experience. regards, dan carpenter
Powered by blists - more mailing lists