lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 May 2022 09:07:38 +0200 (CEST) From: Jiri Kosina <jikos@...nel.org> To: Mario Limonciello <mario.limonciello@....com> cc: basavaraj.natikar@....com, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, David Chang <David.Chang@....com> Subject: Re: [PATCH v2] HID: amd_sfh: Don't show client init failed as error when discovery fails On Thu, 12 May 2022, Mario Limonciello wrote: > When sensor discovery fails, this means that the system doesn't have > any sensors connected and a user should only be notified at most one time. > A message is already displayed at WARN level of "failed to discover, > sensors not enabled". It's pointless to show that the client init failed > at ERR level for the same condition. > > Check the return code and don't display this message in those conditions. > > Fixes: b5d7f43e97da ("HID: amd_sfh: Add support for sensor discovery") > Reported-by: David Chang <David.Chang@....com> > Signed-off-by: Mario Limonciello <mario.limonciello@....com> > --- > v1->v2: > * fix some fat finger typos in commit message > > drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c > index dadc491bbf6b..1441787a154a 100644 > --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c > +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c > @@ -327,7 +327,8 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i > rc = amd_sfh_hid_client_init(privdata); > if (rc) { > amd_sfh_clear_intr(privdata); > - dev_err(&pdev->dev, "amd_sfh_hid_client_init failed\n"); > + if (rc != -EOPNOTSUPP) > + dev_err(&pdev->dev, "amd_sfh_hid_client_init failed\n"); > return rc; Applied, thank you. -- Jiri Kosina SUSE Labs
Powered by blists - more mailing lists