linux-kernel - Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YpCB+Acm5qktFlsT@FVFYT0MHHV2J.usts.net>
Date:   Fri, 27 May 2022 15:47:04 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     mike.kravetz@...cle.com, akpm@...ux-foundation.org,
        david@...hat.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        smuchun@...edance.com
Subject: Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup
 CONFIG_HUGETLB_PAGE_FREE_VMEMMAP*

On Fri, May 27, 2022 at 09:39:41AM +0200, Vlastimil Babka wrote:
> On 4/4/22 09:46, Muchun Song wrote:
> > --- a/mm/hugetlb_vmemmap.c
> > +++ b/mm/hugetlb_vmemmap.c
> > @@ -188,7 +188,7 @@
> >  #define RESERVE_VMEMMAP_NR		1U
> >  #define RESERVE_VMEMMAP_SIZE		(RESERVE_VMEMMAP_NR << PAGE_SHIFT)
> >  
> > -DEFINE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON,
> > +DEFINE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON,
> >  			hugetlb_optimize_vmemmap_key);
> >  EXPORT_SYMBOL(hugetlb_optimize_vmemmap_key);
> 
> Hi,
> 
> looks like just below here you forgot to update:
> 
> static enum vmemmap_optimize_mode vmemmap_optimize_mode =
>         IS_ENABLED(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON);
>

Good catch!

> so it refers to CONFIG name that no longer exists?
>

Right. My bad. I forgot to replace it.  Will fix it ASAP.

Thanks.