linux-kernel - Re: [PATCH crypto] crypto: blake2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YpCGQvpirQWaAiRF@zx2c4.com>
Date:   Fri, 27 May 2022 10:05:22 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        herbert@...dor.apana.org.au, gaochao <gaochao49@...wei.com>,
        Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH crypto] crypto: blake2s - remove shash module

Hey Eric,

On Thu, May 26, 2022 at 11:01:34AM -0700, Eric Biggers wrote:
> On Thu, May 26, 2022 at 11:20:26AM +0200, Jason A. Donenfeld wrote:
> > BLAKE2s has no use as an shash and no use is likely to ever come up.
> 
> I'm not sure about that.  Anyone who is already using shash (for supporting

I'll tweak the language of the commit message.

> More importantly, this is removing quite a bit of test coverage because the
> extra self-tests in crypto/testmgr.c are more comprehensive than what
> lib/crypto/blake2s-selftest.c does.  For example they test the case where the
> input data is misaligned, as well as the case where the code is executed in a
> context where SIMD instructions are unavailable.
> 
> In order for this to be acceptable, I think you'd need to update
> blake2s-selftest.c to be more comprehensive.

There actually already is some alignment tests. But I'll add some more
and also compare implementations. v2 incoming.

Jason