linux-kernel - Re: [PATCH] mm/hugetlb: Remove unnecessary huge_ptep_set_access_flags() in hugetlb_mcopy_atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6f64c75-053d-57e0-a997-176758523d9e@linux.alibaba.com>
Date:   Fri, 27 May 2022 09:34:59 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        mike.kravetz@...cle.com, akpm@...ux-foundation.org,
        songmuchun@...edance.com
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm/hugetlb: Remove unnecessary
 huge_ptep_set_access_flags() in hugetlb_mcopy_atomic_pte()



On 5/26/2022 3:01 PM, Anshuman Khandual wrote:
> 
> 
> On 5/25/22 15:56, Baolin Wang wrote:
>> There is no need to update the hugetlb access flags after just setting the
>> hugetlb page table entry by set_huge_pte_at(), since the page table entry
>> value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags()
> 
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #9:
> value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags()
> 
> total: 0 errors, 1 warnings, 8 lines checked

Sure, will remove checkpatch warning in next verion.

> 
>> in hugetlb_mcopy_atomic_pte().
>>
>> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> 
> Otherwise LGTM,
> 
> Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>

Thanks. Also thanks to Muchun and Mike for reviewing.