linux-kernel - Re: [PATCH] extcon: fsa9480: Drop no-op remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b785922-df17-3f5e-c3a2-be95cf3ea9c2@samsung.com>
Date:   Fri, 27 May 2022 18:09:56 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] extcon: fsa9480: Drop no-op remove function

On 5/26/22 10:07 PM, Uwe Kleine-König wrote:
> A remove callback that just returns 0 is equivalent to no callback at all
> as can be seen in i2c_device_remove(). So simplify accordingly.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/extcon/extcon-fsa9480.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c
> index 08bdedbcdb0d..7cff66c29907 100644
> --- a/drivers/extcon/extcon-fsa9480.c
> +++ b/drivers/extcon/extcon-fsa9480.c
> @@ -324,11 +324,6 @@ static int fsa9480_probe(struct i2c_client *client,
>  	return 0;
>  }
>  
> -static int fsa9480_remove(struct i2c_client *client)
> -{
> -	return 0;
> -}
> -
>  #ifdef CONFIG_PM_SLEEP
>  static int fsa9480_suspend(struct device *dev)
>  {
> @@ -376,7 +371,6 @@ static struct i2c_driver fsa9480_i2c_driver = {
>  		.of_match_table = fsa9480_of_match,
>  	},
>  	.probe			= fsa9480_probe,
> -	.remove			= fsa9480_remove,
>  	.id_table		= fsa9480_id,
>  };
>  
> 
> base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
> 

Applied it for v5.20-rc1. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics