linux-kernel - Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c22e193-2a7b-2537-feff-c4656c022f31@linaro.org>
Date:   Fri, 27 May 2022 12:56:57 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     YueHaibing <yuehaibing@...wei.com>, airlied@...ux.ie,
        daniel@...ll.ch, tzimmermann@...e.de, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF

On 26/05/2022 23:08, Linus Walleij wrote:
> On Wed, May 25, 2022 at 3:36 PM Dmitry Baryshkov
> <dmitry.baryshkov@...aro.org> wrote:
>> On Mon, 23 May 2022 at 15:55, Linus Walleij <linus.walleij@...aro.org> wrote:
> 
>>> Nope, failed:
>>>
>>> $ dim push-branch drm-misc-next
>>> dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"):
>>> Fixes: SHA1 in not pointing at an ancestor:
>>> dim:     f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
>>> dim: ERROR: issues in commits detected, aborting
>>>
>>> I don't know what to do with this, sorry. The other committers are maybe better
>>> with this kind of situations. I think it is designed to stop me from
>>> shooting myself
>>> in the foot.
>>
>> Linus, can we get an ack from you (or anybody else from DRM core) to
>> merge it through drm/msm tree?
> 
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
>> After a second thought, I think the patch contains wrong Fixes tag. It
>> should be:
>>
>> Fixes: 1e0f66420b13 ("drm/display: Introduce a DRM display-helper module")
>>
>> With that in place would we be able to merge it through drm-misc? Does
>> it needs to be resubmitted?
> 
> But it doesn't apply to drm-misc... that's my problem :/

I think it didn't apply because of the Fixes from msm-next.
If we change that to the mentioned commit (1e0f66420b13), then you 
should be able to push it.


-- 
With best wishes
Dmitry