linux-kernel - Re: [PATCH] virtio: Directly use ida

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220527062533-mutt-send-email-mst@kernel.org>
Date:   Fri, 27 May 2022 06:26:02 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     keliu <liuke94@...wei.com>
Cc:     jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio: Directly use ida_alloc()/free()

On Fri, May 27, 2022 at 07:33:02AM +0000, keliu wrote:
> Use ida_alloc()/ida_free() instead of deprecated
> ida_simple_get()/ida_simple_remove() .
> 
> Signed-off-by: keliu <liuke94@...wei.com>

Please Cc people that commented on the original patch. thanks!

> ---
>  drivers/virtio/virtio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index 22f15f444f75..143f94652306 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -413,7 +413,7 @@ int register_virtio_device(struct virtio_device *dev)
>  	device_initialize(&dev->dev);
>  
>  	/* Assign a unique device index and hence name. */
> -	err = ida_simple_get(&virtio_index_ida, 0, 0, GFP_KERNEL);
> +	err = ida_alloc(&virtio_index_ida, GFP_KERNEL);
>  	if (err < 0)
>  		goto out;
>  
> @@ -451,7 +451,7 @@ int register_virtio_device(struct virtio_device *dev)
>  out_of_node_put:
>  	of_node_put(dev->dev.of_node);
>  out_ida_remove:
> -	ida_simple_remove(&virtio_index_ida, dev->index);
> +	ida_free(&virtio_index_ida, dev->index);
>  out:
>  	virtio_add_status(dev, VIRTIO_CONFIG_S_FAILED);
>  	return err;
> @@ -469,7 +469,7 @@ void unregister_virtio_device(struct virtio_device *dev)
>  	int index = dev->index; /* save for after device release */
>  
>  	device_unregister(&dev->dev);
> -	ida_simple_remove(&virtio_index_ida, index);
> +	ida_free(&virtio_index_ida, index);
>  }
>  EXPORT_SYMBOL_GPL(unregister_virtio_device);
>  
> -- 
> 2.25.1