linux-kernel - Re: [PATCH crypto v2] crypto: blake2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YpHx7arH4lLaZuhm@zx2c4.com>
Date:   Sat, 28 May 2022 11:57:01 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        herbert@...dor.apana.org.au, gaochao <gaochao49@...wei.com>,
        Ard Biesheuvel <ardb@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH crypto v2] crypto: blake2s - remove shash module

Hi Eric,

On Fri, May 27, 2022 at 08:59:29PM -0700, Eric Biggers wrote:
> On Fri, May 27, 2022 at 10:11:06AM +0200, Jason A. Donenfeld wrote:
> > BLAKE2s has no use as an shash, with no users of it.
> 
> "no use" => "no known current use".

Ack.

> This doesn't compile on arm, since blake2s_compress_generic() isn't defined.

Grr, thanks. I'll fix that and verify before sending v3.

> Also, the wrong value is being passed for the 'inc' argument.

Are you sure? Not sure I'm seeing what you are on first glance.

> 2048 iterations is also a lot.  Doing a lot of iterations here doesn't
> meaningfully increase the test coverage.

For symmetric things like this, yeah, you're right. I'll reduce that to
a more modest 100 or something.

> And please run checkpatch; those are some very long lines :-(

Ack.

Jason