linux-kernel - Re: mainline build failure due to 8bdc2a190105 ("crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9pS1ODLqJ8rw0hzH5+ZrUW8pwC2nkeD4mLVG4swp8BnQQ@mail.gmail.com>
Date:   Sat, 28 May 2022 13:01:23 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: Re: mainline build failure due to 8bdc2a190105 ("crypto: poly1305 -
 cleanup stray CRYPTO_LIB_POLY1305_RSIZE")

Hi again,

Actually, I think 8bdc2a190105 should just be reverted wholesale.
There are too many headers that depend on it (e.g. caam) even if
there's no .o that winds up using it. I could try to enumerate them
all in kconfig language, but that doesn't seem much cleaner.

[Aside: note that none of this was a problem with my proposed "zinc"
patchset from a few years ago, which cleaned up all this crypto layer
stuff. The frankenstein that landed instead is just a never ending
source of annoying bugs like this one. Until there are larger changes,
I think a lot of the woes of crypto/ are terminally hopeless. :-\]

Jason