linux-kernel - ./include/crypto/poly1305.h:56:46: error: 'CONFIG_CRYPTO_LIB_POLY1305

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <01a7891f-7295-3be2-73f3-5405b1e18f45@molgen.mpg.de>
Date:   Sat, 28 May 2022 16:52:32 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: ./include/crypto/poly1305.h:56:46: error:
 'CONFIG_CRYPTO_LIB_POLY1305_RSIZE' undeclared here

Dear Linux folks,


Fetching the commits from Linus’ tree, and doing `make olddefconfig`, 
the build failed:

```
$ git log --no-decorate --oneline -1 origin/master
9d004b2f4fea Merge tag 'cxl-for-5.19' of 
git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl
$ rm *deb ; make olddefconfig; make bindeb-pkg -j32 && mv ../*deb .
[…]
   CC [M]  lib/crypto/poly1305-donna64.o
   CC [M]  drivers/media/usb/em28xx/em28xx-vbi.o
   CC      arch/x86/kernel/uprobes.o
   CC      kernel/time/itimer.o
   CC      drivers/usb/core/phy.o
   CC [M]  drivers/scsi/sg.o
   CC      lib/iomap_copy.o
   CC [M]  fs/nfs_common/nfsacl.o
   CC [M]  fs/nfs_common/grace.o
   CC      kernel/time/clockevents.o
In file included from ./include/crypto/internal/poly1305.h:11,
                  from lib/crypto/poly1305-donna64.c:11:
./include/crypto/poly1305.h:56:46: error: 
'CONFIG_CRYPTO_LIB_POLY1305_RSIZE' undeclared here (not in a function); 
did you mean 'CONFIG_CRYPTO_POLY1305_MODULE'?
    56 |                 struct poly1305_key 
opaque_r[CONFIG_CRYPTO_LIB_POLY1305_RSIZE];
       | 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       | 
CONFIG_CRYPTO_POLY1305_MODULE
make[5]: *** [scripts/Makefile.build:271: lib/crypto/poly1305-donna64.o] 
Error 1
$ grep POLY .config
CONFIG_CRYPTO_CHACHA20POLY1305=m
# CONFIG_CRYPTO_NHPOLY1305_SSE2 is not set
# CONFIG_CRYPTO_NHPOLY1305_AVX2 is not set
CONFIG_CRYPTO_POLY1305=m
CONFIG_CRYPTO_POLY1305_X86_64=m
CONFIG_CRYPTO_ARCH_HAVE_LIB_POLY1305=m
CONFIG_CRYPTO_LIB_POLY1305_GENERIC=m
# CONFIG_CRYPTO_LIB_POLY1305 is not set
# CONFIG_CRYPTO_LIB_CHACHA20POLY1305 is not set
```

Please find the full problematic config file attached.

Selecting `CONFIG_CRYPTO_LIB_POLY1305=m` works around the issue.

     $ grep POLY .config
     CONFIG_CRYPTO_CHACHA20POLY1305=m
     # CONFIG_CRYPTO_NHPOLY1305_SSE2 is not set
     # CONFIG_CRYPTO_NHPOLY1305_AVX2 is not set
     CONFIG_CRYPTO_POLY1305=m
     CONFIG_CRYPTO_POLY1305_X86_64=m
     CONFIG_CRYPTO_LIB_POLY1305_RSIZE=11
     CONFIG_CRYPTO_ARCH_HAVE_LIB_POLY1305=m
     CONFIG_CRYPTO_LIB_POLY1305_GENERIC=m
     CONFIG_CRYPTO_LIB_POLY1305=m
     # CONFIG_CRYPTO_LIB_CHACHA20POLY1305 is not set

I didn’t bisect, but commit 8bdc2a190105 (crypto: poly1305 - cleanup 
stray CRYPTO_LIB_POLY1305_RSIZE) jumps out for example.


Kind regards,

Paul
View attachment "20220528-linux-crypto-build-bug.config" of type "text/plain" (149252 bytes)