linux-kernel - Re: [PATCH -next] cifs: Remove duplicated include in cifssmb.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5muhKEaxgwJQG7s46h1v+1CHVEP441+x+W4dBk77QbYK2Q@mail.gmail.com>
Date:   Fri, 27 May 2022 20:32:49 -0500
From:   Steve French <smfrench@...il.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] cifs: Remove duplicated include in cifssmb.c

I don't see this line (ie the include cifsfs.h) in fs/cifs/cifssmb.c
anymore could you do a "git blame" and find where that line was added
in for-next?

On Thu, May 26, 2022 at 11:27 PM Yang Li <yang.lee@...ux.alibaba.com> wrote:
>
> Fix following includecheck warning:
> ./fs/cifs/cifssmb.c: cifsfs.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  fs/cifs/cifssmb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index e3457356ec11..193009f1421b 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -28,7 +28,6 @@
>  #include "cifsglob.h"
>  #include "cifsacl.h"
>  #include "cifsproto.h"
> -#include "cifsfs.h"
>  #include "cifs_unicode.h"
>  #include "cifs_debug.h"
>  #include "smb2proto.h"
> --
> 2.20.1.7.g153144c
>


-- 
Thanks,

Steve