linux-kernel - Re: [PATCH] video: fbdev: omap: Add prototype for hwa742_update_window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4460689.LvFx2qVVIh@dell>
Date:   Sun, 29 May 2022 13:14:56 +0200
From:   Janusz Krzysztofik <jmkrzyszt@...il.com>
To:     Helge Deller <deller@....de>, Tony Lindgren <tony@...mide.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Tomi Valkeinen <tomba@...nel.org>
Cc:     linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Imre Deak <imre.deak@...idboot.com>,
        Trilok Soni <soni.trilok@...il.com>,
        Janusz Krzysztofik <jmkrzyszt@...il.com>
Subject: Re: [PATCH] video: fbdev: omap: Add prototype for hwa742_update_window_async() to avoid build warning

Hi Helge,

On Sunday, 29 May 2022 08:47:51 CEST Helge Deller wrote:
> The symbol hwa742_update_window_async() is exported, but there is no
> prototype defined for it. That's why gcc complains:
> 
> drivers-video-fbdev-omap-hwa742.c:warning:no-previous-prototype-for-hwa742_update_window_async
> 
> Add the prototype, but I wonder if we couldn't drop exporting the symbol
> instead. Since omapfb_update_window_async() is exported the same way,
> are there any users outside of the tree?

It looks like there are no non-local users of any of those two functions 
either, so we could make them static, and I'm not aware of any out of tree 
users, but let's ask more deeply involved people.  Tony, Aaro, Tomi, can 
you please confirm?

Thanks,
Janusz

> 
> Signed-off-by: Helge Deller <deller@....de>
> 
> diff --git a/drivers/video/fbdev/omap/omapfb.h b/drivers/video/fbdev/omap/omapfb.h
> index d930152c289c..0c753ccbc1c0 100644
> --- a/drivers/video/fbdev/omap/omapfb.h
> +++ b/drivers/video/fbdev/omap/omapfb.h
> @@ -229,5 +229,9 @@ extern int  omapfb_update_window_async(struct fb_info *fbi,
>  				       struct omapfb_update_window *win,
>  				       void (*callback)(void *),
>  				       void *callback_data);
> +extern int  hwa742_update_window_async(struct fb_info *fbi,
> +				       struct omapfb_update_window *win,
> +				       void (*callback)(void *),
> +				       void *callback_data);
> 
>  #endif /* __OMAPFB_H */
>