linux-kernel - Re: [PATCH 2/3] [PATCH] dt-bindings: arm: add BCM6878 soc to binding document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 29 May 2022 16:00:01 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Anand Gore <anand.gore@...adcom.com>,
        Linux ARM List <linux-arm-kernel@...ts.infradead.org>
Cc:     joel.peshkin@...adcom.com, kursad.oney@...adcom.com,
        samyon.furman@...adcom.com,
        William Zhang <william.zhang@...adcom.com>,
        dan.beygelman@...adcom.com, tomer.yacoby@...adcom.com,
        Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        florian.fainelli@...adcom.com,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] [PATCH] dt-bindings: arm: add BCM6878 soc to binding
 document

On 27/05/2022 19:09, Anand Gore wrote:
> Add BCM6878 SOC device tree description to bcmbca binding document.
> 
> Signed-off-by: Anand Gore <anand.gore@...adcom.com>

Your subject is corrupted. Anyway you made it a bit over-complicated. No
need to say "to binding document" as the prefix explains it. So this
should be (don't forget the actual subarch prefix):

	dt-bindings: arm: brcm: add BCM6878 soc

Same applies to your other patches.

> ---
> 
>  .../devicetree/bindings/arm/bcm/brcm,bcmbca.yaml          | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> index a63e355ba8f9..4b4af2b1f277 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> @@ -43,6 +43,14 @@ properties:
>            - const: brcm,bcmbca
>  
>  
> +      - description: BCM6878 based boards
> +        items:
> +          - enum:
> +              - brcm,bcm96878
> +          - const: brcm,bcm6878
> +          - const: brcm,bcmbca
> +
> +

Same as before - no need for two blank lines.

>  additionalProperties: true
>  
>  ...


Best regards,
Krzysztof