[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8123f029-8d0b-be52-ba8d-8458f424ee32@linaro.org>
Date: Sun, 29 May 2022 16:26:08 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tom Fitzhenry <tom@...-fitzhenry.me.uk>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
linux-rockchip@...ts.infradead.org
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Samuel Holland <samuel@...lland.org>,
Ondrej Jirman <x@....cz>, Martijn Braam <martijn@...xit.nl>,
Ondrej Jirman <megous@...ous.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64
PinePhone Pro
On 29/05/2022 05:17, Tom Fitzhenry wrote:
> This is a basic DT that includes only features that are already
> supported by mainline drivers.
>
> Tested to work: booting from eMMC, WiFi, charging.
>
> Future patches will flesh out the DT. Some components, e.g. the panel,
> are awaiting driver mainlining.
>
> This is derived from a combination of https://gitlab.com/pine64-org/linux
> and https://megous.com/git/linux.
>
> https://wiki.pine64.org/wiki/PinePhone_Pro
>
> Co-developed-by: Ondrej Jirman <megous@...ous.com>
> Co-developed-by: Martijn Braam <martijn@...xit.nl>
> Signed-off-by: Tom Fitzhenry <tom@...-fitzhenry.me.uk>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../dts/rockchip/rk3399-pinephone-pro.dts | 939 ++++++++++++++++++
> 2 files changed, 940 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 4ae9f35434b8..c00e7922d974 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -41,6 +41,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-neo4.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-r4s.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-orangepi.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-pinebook-pro.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-pinephone-pro.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc-mezzanine.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> new file mode 100644
> index 000000000000..b1a486db1dfe
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -0,0 +1,939 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2020 Martijn Braam <martijn@...xit.nl>
> + * Copyright (c) 2021 Kamil TrzciĆski <ayufan@...fan.eu>
> + */
> +
> +// PinePhone Pro datasheet: https://files.pine64.org/doc/PinePhonePro/PinephonePro-Schematic-V1.0-20211127.pdf
> +
> +/dts-v1/;
> +#include <dt-bindings/input/gpio-keys.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/usb/pd.h>
> +#include <dt-bindings/leds/common.h>
> +#include "rk3399.dtsi"
> +#include "rk3399-opp.dtsi"
> +
> +/ {
> + model = "Pine64 PinePhonePro";
> + compatible = "pine64,pinephone-pro", "rockchip,rk3399";
> +
> + chosen {
> + bootargs = "earlycon=uart8250,mmio32,0xff1a0000";
earlycon is debugging piece so it should not be in generic DTS.
Best regards,
Krzysztof
Powered by blists - more mailing lists