linux-kernel - Re: [PATCH] riscv: add correct as-options for assembly in modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a624c79-c4c5-ab7c-f438-134822abfa14@codethink.co.uk>
Date:   Sun, 29 May 2022 16:23:45 +0100
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     linux-kernel@...ts.codethink.co.uk, linux-riscv@...ts.infradead.org
Cc:     palmer@...belt.com, aou@...s.berkeley.edu,
        linux-kernel@...r.kernel.org, Bin Meng <bmeng.cn@...il.com>
Subject: Re: [PATCH] riscv: add correct as-options for assembly in modules

On 29/05/2022 16:19, Ben Dooks wrote:
> When trying to load modules built for riscv which include assembly
> the kernel loader errors with "unexpected relocation type 'R_RISCV_ALIGN'"
> due to R_RISCV_ALIGN relocations being generated by the assembler.
> 
> In commit 7a8e7da42250138 ("RISC-V: Fixes to module loading") the
> CFLAGS have -mno-relax added. This however does not get applied to
> KBUILD_AFLAGS_MODULE so when a module builds a .S file, the -mno-relax
> is not passed and the above error is seen. Fix it by adding the flags
> '-Wa,-mno-relax' to KBUILD_AFLAGS_MODULE.
> 
> This may have been fixed in gcc, in:
>   https://github.com/gcc-mirror/gcc/commit/3b0a7d624e64eeb81e4d5e8c62c46d86ef521857
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> Reviewed-by: Bin Meng <bmeng.cn@...il.com>
Apologies, this was the wrong branch. Will resen

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html